Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETC Spiral EVM configuration #6524

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

diega
Copy link
Contributor

@diega diega commented Feb 5, 2024

PR description

During the last ETC network upgrade, Besu nodes got stalled because, inadvertently, EIP-4399 was included instead of omitted.

For the future, we'll also test omissions to the protocol and not only additions.

Copy link

github-actions bot commented Feb 5, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for full fluent API support for classic forks?

@diega
Copy link
Contributor Author

diega commented Feb 5, 2024

@shemnon I think ProtocolSpecs fluency is pretty good, is that fluent API the one that you mean?

@shemnon
Copy link
Contributor

shemnon commented Feb 5, 2024

APIs from this directory - https://github.com/hyperledger/besu/blob/d7e5b261141da6cbb4a8131ed2feb1603e3e68f8/evm/src/main/java/org/hyperledger/besu/evm/fluent

Guido has a fuzzer he uses there. But I'm not sure it would have caught the DIFFICULTY/RANDAO swap, even against core-geth.

@diega
Copy link
Contributor Author

diega commented Feb 5, 2024

That sounds really interesting, do you know where I can find some documentation on how to run the fuzzer with Besu's EVM?

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could use a changelog entry

Signed-off-by: Diego López León <dieguitoll@gmail.com>
@macfarla macfarla merged commit c31403d into hyperledger:main Feb 6, 2024
80 checks passed
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Publish job is failing due to a missing javadoc

> Task :evm:javadoc
/home/circleci/project/evm/src/main/java/org/hyperledger/besu/evm/ClassicEVMs.java:29: warning: no comment
public class ClassicEVMs {
       ^

@diega diega mentioned this pull request Feb 6, 2024
@diega diega deleted the spiral_evm branch February 6, 2024 13:24
jflo pushed a commit that referenced this pull request Feb 9, 2024
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants