-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ETC Spiral EVM configuration #6524
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for full fluent API support for classic forks?
@shemnon I think ProtocolSpecs fluency is pretty good, is that fluent API the one that you mean? |
APIs from this directory - https://github.com/hyperledger/besu/blob/d7e5b261141da6cbb4a8131ed2feb1603e3e68f8/evm/src/main/java/org/hyperledger/besu/evm/fluent Guido has a fuzzer he uses there. But I'm not sure it would have caught the DIFFICULTY/RANDAO swap, even against core-geth. |
That sounds really interesting, do you know where I can find some documentation on how to run the fuzzer with Besu's EVM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could use a changelog entry
Signed-off-by: Diego López León <dieguitoll@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI Publish job is failing due to a missing javadoc
> Task :evm:javadoc
/home/circleci/project/evm/src/main/java/org/hyperledger/besu/evm/ClassicEVMs.java:29: warning: no comment
public class ClassicEVMs {
^
Signed-off-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
PR description
During the last ETC network upgrade, Besu nodes got stalled because, inadvertently, EIP-4399 was included instead of omitted.
For the future, we'll also test omissions to the protocol and not only additions.