Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Reference tests v13.1 #6574

Merged
merged 22 commits into from
Feb 16, 2024
Merged

Apply Reference tests v13.1 #6574

merged 22 commits into from
Feb 16, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Feb 14, 2024

PR description

Apply v 13.1 of the reference tests, includes test related fixes around initing the KZG precompile, uint64s in timestamps and blob gas, and some formatting cleanup.

Fixed Issue(s)

jflo and others added 16 commits February 8, 2024 10:50
@jflo
invalidate txs below blob base fee
602b652 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
updates tests to provide blob prices
b018900 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
undoing debug adjustment
ad6d625 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
correction to reftests
d2ca94d 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
spotless
d7590ca 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo @fab-10
Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/main…
e1ea030 
…net/PermissionTransactionValidator.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo @fab-10
Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/main…
98a45d7 
…net/TransactionValidator.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo @fab-10
Update ethereum/core/src/test/java/org/hyperledger/besu/ethereum/main…
848950c 
…net/MainnetTransactionValidatorTest.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
new enum
e90991c 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
leverage validator option to include underpriced tx from the pool
6e57ad3 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@shemnon
Reference Tests v13.1
f4d5390 
Update to new reference tests for cancun.
* Init KZG as part of ReferenceTestProtocolSchedules

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@jflo
Merge branch 'main' into blobGasFeeChecking
16e7c35
@shemnon
Merge branch 'blobGasFeeChecking' into reftests-13.1
44ad40a
@shemnon
Merge branch 'main' of github.com:hyperledger/besu into reftests-13.1
a422e06 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
fix unsigned long errors
cdf9c00 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon @jflo
block validation on borked blobGasUsed
7c94dcd 
Co-authored-by: : Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@shemnon
I detest Java's lack of unsigned integer support.
7489602 
I detest it, for that there are unit tests.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
macfarla
macfarla approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit in error message

evm/src/main/java/org/hyperledger/besu/evm/internal/Words.java Outdated Show resolved Hide resolved
shemnon and others added 5 commits February 15, 2024 06:53
@shemnon
Merge branch 'main' of github.com:hyperledger/besu into reftests-13.1
5248180 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
changelog
8293a13 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@macfarla
typo
c3cadeb 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' into reftests-13.1
efac082
@shemnon
merge main
68d8750 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon enabled auto-merge (squash) February 16, 2024 17:49
@shemnon shemnon enabled auto-merge (squash) February 16, 2024 17:50
@shemnon shemnon merged commit 9e2f471 into hyperledger:main Feb 16, 2024
50 checks passed
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
@shemnon @jflo
@macfarla @suraneti
Apply Reference tests v13.1 (hyperledger#6574)
58e75cc 
Update to new reference tests for cancun.
* Init KZG as part of ReferenceTestProtocolSchedules
* fix unsigned long errors
* block validation on borked blobGasUsed

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shemnon @macfarla @jflo