Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Forest pruning #6810

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 26, 2024

PR description

Forest pruning has been removed, it was deprecated since 24.1.0. In case you are still using it you must now remove any of the following options: pruning-enabled, pruning-blocks-retained and pruning-block-confirmations, from you configuration, and you may want to consider switching to Bonsai.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the remove-forest-pruning branch 3 times, most recently from 9a00fea to d89f343 Compare March 27, 2024 11:09
@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 27, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review March 27, 2024 13:00
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 27, 2024
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) March 29, 2024 15:00
# Conflicts:
#	CHANGELOG.md
#	besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java
#	besu/src/test/java/org/hyperledger/besu/cli/PrivacyOptionsTest.java
@fab-10 fab-10 merged commit d8e1e17 into hyperledger:main Mar 29, 2024
42 checks passed
@fab-10 fab-10 deleted the remove-forest-pruning branch March 29, 2024 18:06
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* Remove deprecated Forest pruning

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Update CHANGELOG.md

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants