Error out on permissions config accounts-allowlist validation errors.[#7138] #7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- corrects gas checking in AUTH / AUTHCALL - fixes bug in engine api v4 - corrects gas pricing in BLOCKHASH --------- Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: Jason Frame <jasonwframe@gmail.com> Signed-off-by: krishnannarayanan <krsh24@gmail.com>
Signed-off-by: krishnannarayanan <krsh24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When allow_accountlist in "permissions_config.toml" have duplicate or incorrect Ethereum addresses the functionality is to throw IllegalStateException during start-up. Currently, the validation errors are ignored and not logged to the log file as well.
This change will ensure the config file is valid before starting up the node.
Fixed Issue(s)
#7138
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests