Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift creation of plugin context to BesuCommand for now #7625

Merged
merged 10 commits into from
Sep 18, 2024
Merged

shift creation of plugin context to BesuCommand for now #7625

merged 10 commits into from
Sep 18, 2024

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Sep 16, 2024 •
edited
Loading

  • Corrects a regression where custom plugin services are not initialized correctly.
  • BesuCommand: No longer requires metricsSystem supplier and memoization.
  • Shifts provision of plugin context to BesuCommand.
  • ProcessBesuNodeRunner: factors out command line arg composition into a new method for future modularization.

@jflo
shift creation of plugin context to BesuCommand for now
fd44865 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
can't recreate component
81174b0 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
spotless and mocking
78ea6ee 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
can't actually make it a singleton with 2 provider methods
5fc2e09 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
300+ lines warrants its own method
791a002 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
mock component will provide a no-op metrics sys
c1f97f0 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo jflo marked this pull request as ready for review September 18, 2024 02:16
@jflo
missing import
90bab9c 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
fab-10
fab-10 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a suggestion to split in multiple PRs when possible

@jflo jflo enabled auto-merge (squash) September 18, 2024 14:07
@jflo jflo merged commit 7d3e376 into hyperledger:main Sep 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 approved these changes

@matkt matkt Awaiting requested review from matkt

@Gabriel-Trintinalia Gabriel-Trintinalia Awaiting requested review from Gabriel-Trintinalia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @fab-10