Expose chain ID in the BlockchainService plugin API #7702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo
approved these changes
Oct 1, 2024
fab-10
approved these changes
Oct 1, 2024
| @@ -182,4 +183,12 @@ public BlockBody getBlockBody() { | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| @Override | |||
| public Optional<BigInteger> getChainId() { | |||
There was a problem hiding this comment.
Since I like fail fast, I am tempted to raise an error is the service is used before it is initialized, but this probably is for another PR, since it can apply to other methods as well
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
2fehee
pushed a commit
to 2fehee/besu
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>Signed-off-by: Chulhee lee <leefehee@naver.com>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Expose chain ID in the BlockchainService plugin API
Fixed Issue(s)
fixes #7630