Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLAKE] disable CliqueProposeRpcAcceptanceTests x 2 #8035

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

macfarla
Copy link
Contributor

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

PR description

Fixed Issue(s)

Refs #7973

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@Matilda-Clerke Matilda-Clerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have issues raised to try to fix the flakiness?

Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor Author

LGTM. Do we have issues raised to try to fix the flakiness?

there is #7973 which is linked to this PR but I won't close it. if you look for the flake label there's a few issues open. You're welcome to try and fix some!

@macfarla macfarla enabled auto-merge (squash) December 17, 2024 06:31
@macfarla macfarla merged commit 4aa89b2 into hyperledger:main Dec 17, 2024
43 checks passed
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@macfarla macfarla deleted the flake-clique-rpc-test branch December 19, 2024 07:18
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants