Exclude empty requests from requests hash #8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
approved these changes
Dec 17, 2024
…loadV4 Fixes ethereum/execution-apis#599 change to EIP-7685 Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…com:daniellehrner/besu into feat/issue-7947/exclude_empty_requests_hash
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…T8nExecutor Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
* exclude empty requests from requests hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Exclude empty requests and prepend request type byte in engine_getPayloadV4 Fixes ethereum/execution-apis#599 change to EIP-7685 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * fix test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix prague tests: change request hash, reorder json elements Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix extracting of request for new payload Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix test by fixing request object creation Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * set request type to only one byte, fixed creation of request list in T8nExecutor Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix expected json output to exclude empty requests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
If a request is empty it will be ignored from the calculation of the request hash. This changes the hash for empty requests, which needed to be updated in the tests
Fixed Issue(s)
fixes #7947
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests