Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-18489] fix links in 2.1 release docs #2676

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

nikhil550
Copy link
Contributor

Signed-off-by: Nikhil Gupta ngupta@symbridge.com

Type of change

  • Bug fix
  • Documentation update

Description

Fix links detected by the link checker in the release-2.1 docs

@nikhil550 nikhil550 marked this pull request as ready for review June 14, 2021 14:45
@nikhil550 nikhil550 requested review from a team as code owners June 14, 2021 14:45
denali49
denali49 previously approved these changes Jun 14, 2021
Copy link
Contributor

@denali49 denali49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Nik.

Signed-off-by: Nikhil Gupta <ngupta@symbridge.com>
Copy link
Contributor

@denali49 denali49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Nik.

@ryjones ryjones enabled auto-merge (rebase) June 15, 2021 23:28
@ryjones
Copy link
Member

ryjones commented Jun 15, 2021

@denyeart it looks like this is tripping up on a go modules requirement. Should it be force-merged? hashicorp/hcl#449

@denyeart
Copy link
Contributor

@denyeart it looks like this is tripping up on a go modules requirement. Should it be force-merged? hashicorp/hcl#449

Yeah, I'll force merge. Anybody know why this Go dependency fails on 2.0 and 2.1, but not 2.2 or 2.3?

@denyeart denyeart disabled auto-merge June 16, 2021 18:42
@denyeart denyeart merged commit 92f7a03 into hyperledger:release-2.1 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants