Update deploy_chaincode.md package command docs
#3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the default behavior of `peer lifecycle chaincode package`, which does *not* include node_modules in the resulting tar.gz package for chaincode. The existing step of `npm install` and quote "If the command is successful, the JavaScript packages will be installed inside a `node_modules` folder. Now that we that have our dependencies, we can create the chaincode package." would lead a reader to believe that `node_modules` are included when they are not. Also added more detail about what chaincode services allow `node_modules` when packaged manually.
|
Thank you for the contribution! Please sign the commit using the instructions at https://github.com/hyperledger/fabric/pull/3191/checks?check_run_id=4941497881 |
|
@mbwhite Since we haven't received a signed commit yet, could you maybe move this one forward in a new PR? Take the inspiration from this PR and add any other clarifications that you think are needed... |
ale-linux
approved these changes
Oct 27, 2022
|
@curldapps2 thanks for your contribution, could you please take care of the DCO so that we can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the default behavior of
peer lifecycle chaincode package, which does not include node_modules in the resulting tar.gz package for chaincode. The existing step ofnpm installand quote "If the command is successful, the JavaScript packages will be installed inside anode_modulesfolder. Now that we that have our dependencies, we can create the chaincode package." would lead a reader to believe thatnode_modulesare included when they are not.Also added more detail about what chaincode services allow
node_moduleswhen packaged manually.Type of change
Description
Additional details
Related issues