[FAB-17196] Fix broken md structures in docs #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satota2
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
guoger
reviewed
Dec 9, 2019
| * Here is an example of the `peer lifecycle chaincode checkcommitreadiness` command, | ||
| which checks a chaincode named `mycc` at version `1.0` on channel `mychannel`. | ||
|
|
||
| ``` | ||
| export ORDERER_CA=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/ordererOrganizations/example.com/orderers/orderer.example.com/msp/tlscacerts/tlsca.example.com-cert.pem | ||
| . |
There was a problem hiding this comment.
i believe this dot is not necessary
There was a problem hiding this comment.
Thank you for having reviews.
New patch removes unnecessary dots in the entire file.
| @@ -109,16 +109,19 @@ channel `mychannel`. | |||
| ### peer lifecycle chaincode checkcommitreadiness example | |||
|
|
|||
| You can check whether a chaincode definition is ready to be committed using the | |||
| ``peer lifecycle chaincode checkcommitreadiness command, which will return | |||
There was a problem hiding this comment.
it's not yours but we've been unnecessarily using double backticks in this file. would be nice to convert them to single backtick
There was a problem hiding this comment.
Thank you for having reviews.
New patch converts unnecessary double backticks to single backtick in the entire file.
This patch fixes broken markdown structures in documents on peerlifecycle commands. Also, this patch includes a minor fix for removing references to alpha (ref. FAB-16157). In addtion, this patch removes unnecessary dots and double backticks in the entire file. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
denyeart
approved these changes
Dec 10, 2019
jyellick
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes broken markdown structures in documents on peerlifecycle commands.
Also, this patch includes a minor fix for removing references to alpha (ref. FAB-16157).
Signed-off-by: Tatsuya Sato Tatsuya.Sato@hal.hitachi.com
Type of change
Description
This patch fixes broken markdown structures in documents on peerlifecycle commands.
Also, this patch includes a minor fix for removing references to alpha (ref. FAB-16157).
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17196
https://jira.hyperledger.org/browse/FAB-16157