FAB-17170 Peer CLI should encode mdata lowercase #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
Once upon a time, the JSON fields in the chaincode package metadata.json were upper case. The peer CLI was written to reflect this fact. When they were changed to lower-case, the peer CLI was not updated, but because of the fuzzy JSON matching rules in the golang JSON decoded it was not noticed. However, for external builders, the inconsistency is more likely to be noticed as tools like jq etc. may not default to this same fuzzy case-insensitive matching. This change simply modifies the peer CLI to encode the metadata fields as lower case. Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
jyellick
force-pushed
the
FAB-17170-lowercase-json
branch
from
52dc6cd
to
84845ff
Compare
|
Would self +2 if I could, this one is trivial. |
denyeart
approved these changes
Dec 10, 2019
muralisrini
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Once upon a time, the JSON fields in the chaincode package metadata.json
were upper case. The peer CLI was written to reflect this fact. When
they were changed to lower-case, the peer CLI was not updated, but
because of the fuzzy JSON matching rules in the golang JSON decoded it
was not noticed. However, for external builders, the inconsistency is
more likely to be noticed as tools like jq etc. may not default to this
same fuzzy case-insensitive matching.
This change simply modifies the peer CLI to encode the metadata fields
as lower case.