don't wait to expire dead endpoints if exiting #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Mar 31, 2020
| return | ||
| select { | ||
| case c.deadEndpoints <- pkiID: | ||
| case <-c.exitChan: |
|
That would be the other flake I mean. /ci-run |
|
AZP build triggered! |
|
flake is https://jira.hyperledger.org/browse/FAB-16233 /ci-run |
|
AZP build triggered! |
yacovm
requested changes
Apr 1, 2020
Change-Id: I4253ab37d34ae90d60532f7769cccd751c799fdd Signed-off-by: Morgan Bauer <mbauer@us.ibm.com>
|
moved to separate PR #983. I would suggest merging that one first if this keeps flakin. |
yacovm
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
deadEndpoints channel gets filled up. Exit occurs, and deadEndpoints is not drained. We can avoid putting more into the channel and creating hanging goroutines (many many many of them, this fills up my memory). There are still messages that get dropped on the floor sometimes that will cause a different hang.
Additional details
Seeing what looked like unbounded memory usage when running this in a loop.
There are anywhere between 80 and 600 messages for each side of the connection.
Each iteration through the loop results in a timer being created.
Avoid that and create one at the test start.
Related issues
FAB-17451 I reported this from #954 (comment)