Point ERC20/ERC721 connector at deployed contract address #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire docker-compose.yml file will now be rewritten after first-time setup is complete. This allows it to pick up on new things such as deployed contracts. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
As a convenience for editing the Docker config (which was previously supported by editing the YAML by hand prior to having it copied to "runtime"), stub out a docker-compose.override.yml file and direct the user to edit that instead. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
onelapahead
reviewed
Apr 27, 2022
| @@ -34,4 +34,5 @@ require ( | |||
| golang.org/x/sys v0.0.0-20210420205809-ac73e9fd8988 // indirect | |||
| golang.org/x/text v0.3.4 // indirect | |||
| gopkg.in/yaml.v2 v2.4.0 | |||
There was a problem hiding this comment.
is v2 still needed then?
There was a problem hiding this comment.
I think a bunch of our dependencies pull it in.
| @@ -31,6 +32,17 @@ type ERC20ERC721Provider struct { | |||
| Stack *types.Stack | |||
| } | |||
|
|
|||
| type HexAddress string | |||
nguyer
reviewed
Apr 27, 2022
| if err != nil { | ||
| return err | ||
| } | ||
| bytes = append(bytes, yamlBytes...) |
There was a problem hiding this comment.
Yea... wondered if there was a more efficient way?
|
Changes look good to me. I'm going to run E2E on these changes in a few variations as a quick smoke test. |
This was referenced Apr 27, 2022
nguyer
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes multiple changes to how the
docker-compose.ymlfile is handled:docker-compose.ymlhas moved back up to the root directory of the stack (instead of being placed in "init" and "runtime" subfolders). A simple migration check will copy it out of "runtime" into the parent folder if needed.docker-compose.ymlfile will now be rewritten after first-time setup is complete. This allows it to pick up on new things such as deployed contracts. It is notated at the top with comments indicating it is a generated file and should not be edited.docker-compose.override.ymlfile, as supported by docker-compose.