Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E2E script to use manifest file #251

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Update E2E script to use manifest file #251

merged 3 commits into from
Oct 15, 2021

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Oct 14, 2021

Opening this as a draft PR for now. It will fail until we merge and tag/release hyperledger/firefly-cli#112. This uses the new CLI flag when running E2E tests to ensure that the images tested, are the specific ones listed in the manifest.json for the FireFly Core commit being tested.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@peterbroadhurst
Copy link
Contributor

v0.0.34 adds hyperledger/firefly-cli#112

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #251 (f967d84) into main (83507dc) will not change coverage.
The diff coverage is n/a.

❗ Current head f967d84 differs from pull request most recent head b5ef605. Consider uploading reports for the commit b5ef605 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          214       214           
  Lines        11820     11820           
=========================================
  Hits         11820     11820           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83507dc...b5ef605. Read the comment docs.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer marked this pull request as ready for review October 15, 2021 13:48
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see how this has all unfolded, without ending up with a mess of new Bash 🤖

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer merged commit b5fd5e3 into main Oct 15, 2021
@nguyer nguyer deleted the e2e-manifest branch October 15, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants