-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to handle recursive structures in swagger - depends on kin-openapi change #337
Conversation
kin-openapi change Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Looks like upstream PR has been merged 🥳 |
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@@ -31,7 +31,7 @@ import ( | |||
) | |||
|
|||
func newSubscriptionSchemaGenerator(ctx context.Context) string { | |||
baseSchema, _, _ := openapi3gen.NewSchemaRefForValue(&fftypes.Subscription{}) | |||
baseSchema, _ := openapi3gen.NewSchemaRefForValue(&fftypes.Subscription{}, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any issue with passing nil here? @peterbroadhurst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think that's fine - would only be a problem if we ever introduce a recursive schema into one of the subscription types 👍
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
go.mod
replace stripping out before it can move out of draftffenum
etc. tags on outputs (only inputs)