Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : mediator add to alias should not store duplicated alias #19

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix : mediator add to alias should not store duplicated alias #19

merged 2 commits into from
Jun 27, 2023

Conversation

shaileshp0110
Copy link
Contributor

@shaileshp0110 shaileshp0110 commented Jun 26, 2023 •
edited by mineme0110
Loading

ATL-5002

FabioPinheiro
FabioPinheiro approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.
But I am concerned about what is the mediator replying to the user when this happens. (there are zero changes on DB)
We use that number sometimes or at least I intended but I need to check the code.

@mineme0110
Copy link
Contributor

Makes sense to me. But I am concerned about what is the mediator replying to the user when this happens. (there are zero changes on DB) We use that number sometimes or at least I intended but I need to check the code.

Currently, the reply is the message is success, We can discuss tommorow

@FabioPinheiro
Copy link
Contributor

okay that looks awesome thanks

@mineme0110 mineme0110 merged commit ae70000 into main Jun 27, 2023
1 check passed
@mineme0110 mineme0110 deleted the fix-duplicate-alias branch June 27, 2023 10:12
mineme0110 added a commit that referenced this pull request Apr 30, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
73abbc8 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
mineme0110 added a commit that referenced this pull request Apr 30, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
7567ea5 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh <Patil>
mineme0110 added a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
0afb081 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh <Patil>
mineme0110 added a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
55a0f62 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh Patil <shaileshp@gmail.com>
mineme0110 added a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
fba240b 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh Patil <shaileshp@gmail.com>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
26e4655 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh Patil <shaileshp@gmail.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
97b49a5 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh Patil <shaileshp@gmail.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@shaileshp0110 @mineme0110
fix : mediator add to alias should not store duplicated alias (#19)
a9cdd03 
* add to alias is a set, and not duplicates fixed ussing mongo addtoset

* Added tests and Updated the reposne to nochnage in case of the noupdate was done

---------

Co-authored-by: Shailesh Patil <shailesh.patil@iohk.io>
Signed-off-by: Shailesh Patil <shaileshp@gmail.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaileshp0110 @mineme0110 @FabioPinheiro