Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Sovrin and Node GHA CD #101

Closed
wants to merge 19 commits into from
Closed

[WIP] Sovrin and Node GHA CD #101

wants to merge 19 commits into from

Conversation

askolesov
Copy link
Contributor

No description provided.

@askolesov askolesov changed the title Sovrin cd [WIP] Sovrin and Node GHA CD Feb 26, 2021
@WadeBarnes WadeBarnes self-requested a review March 29, 2021 12:10
@WadeBarnes
Copy link
Member

@askolesov, DCO sign-off needs to be fixed.

@askolesov
Copy link
Contributor Author

@WadeBarnes Sorry, It's another dead PR. Better to close in order not to confuse people.

@askolesov askolesov closed this Apr 5, 2021
@askolesov askolesov deleted the sovrin-cd branch April 12, 2021 15:54
@askolesov askolesov mentioned this pull request Apr 12, 2021
Closed
@devinleighsmith
Copy link
Contributor

@askolesov since you were working on this, were you able to get these tests to pass? noticing that you've fixed a lot of the issues that I've run into today, such as needing to pin pip in the client to <10.

If so, what dependency versions worked for you, if you still have that information?

@devinleighsmith
Copy link
Contributor

oh interesting, looks like this PR corresponds to a PR within sovrin for a GHA, which appears to include all of the env vars that you were using with run.sh

will give that a go.

@askolesov
Copy link
Contributor Author

@devinleighsmith Hi, better look here:
https://github.com/hyperledger/indy-node/pull/1662/files

I started with Sovrin but switched to Node, was able to run some system tests, and then was pulled to another project.

@devinleighsmith
Copy link
Contributor

@askolesov thanks for this.

@devinleighsmith devinleighsmith mentioned this pull request Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@ashcherbakov ashcherbakov Awaiting requested review from ashcherbakov

@skhoroshavin skhoroshavin Awaiting requested review from skhoroshavin

@Toktar Toktar Awaiting requested review from Toktar

@VladimirWork VladimirWork Awaiting requested review from VladimirWork

@WadeBarnes WadeBarnes Awaiting requested review from WadeBarnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askolesov @WadeBarnes @devinleighsmith