-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate an optional title parameter into the AddAssetQuantity and SubtractAssetQuantity function for the Python client, aligning with the enhanced functionality within Iroha Core for optimized message communication. #157
Incorporate an optional title parameter into the AddAssetQuantity and SubtractAssetQuantity function for the Python client, aligning with the enhanced functionality within Iroha Core for optimized message communication. #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed *.proto file, but You need to generate code. Please execute:
scripts/compile-proto.py
Generated files added after adding new parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay.
54d73c1
to
490be39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commands.proto
looks OK, rest of files are generated, so probably they are also OK. So next thing is to finish: hyperledger/iroha#4003
…new parameters for advanced message communication. Implement corresponding handling capabilities in Iroha Core to ensure seamless integration and optimal performance. Signed-off-by: dominious1 <piotr567@proton.me>
490be39
to
7e63a5a
Compare
Signed-off-by: dominious1 <piotr567@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesterday I was having meeting with @dominious1 and @andprogrammer . We corrected name from title
->description
and regenerated python files from protobuf with official script(https://github.com/hyperledger/iroha-python/blob/main/scripts/compile-proto.py).
Fantastic pull request. Thank you. |
ac79788
to
ac4d58f
Compare
To make sure that everything is working I checked:
mkdir checking_internship
cd checking_internship
python -m venv $(pwd)/venv
source ./venv/bin/activate
pip3 install git+https://github.com/dominious1/iroha-python.git@addtitleparamtoAddAssetQuantity
def add_coin_to_admin_with_description(asset: str, amount='1000.00', desc=''):
"""
Add provided amount of specific units to admin account
"""
tx = iroha.transaction([
iroha.command('AddAssetQuantity',
asset_id=asset, amount=amount, description=desc)
])
IrohaCrypto.sign_transaction(tx, ADMIN_PRIVATE_KEY)
send_transaction_and_print_status(tx)
IMO it is done - fully working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution. I'm concerned that we have blobs inside the Python code, and this is a topic I'd like to discuss separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution. I'm concerned that we have blobs inside the Python code, and this is a topic I'd like to discuss separately.
Introduce an optional
title
parameter to the commands.proto bufs GRPC forAddAssetQuantity
andSubtractAssetQuantity
. This enhancement facilitates a more flexible and comprehensive feature set, aligning with evolving requirements and ensuring seamless integration with the protobuf-based GRPC implementation.Technology stack:
To regenerate files based on predefined protobufs I used iroha-python/scripts/compile-proto.py
This is part of internship project:
https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments
Link to PR to iroha repository compatible with those changes:
hyperledger/iroha#4003