Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify macro generation of versioned containers #1675

Closed
mversic opened this issue Dec 4, 2021 · 2 comments
Closed

Simplify macro generation of versioned containers #1675

mversic opened this issue Dec 4, 2021 · 2 comments
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Dec 4, 2021

Our current macro implementation of versioned containers creates wrapper structure for each versioned item. Instead of using wrapper structure we should use private type alias. This will reduce the amount of code generated by the macro and will make our API look much nicer
@mversic mversic mentioned this issue Dec 4, 2021
Merged
@kuvaldini
Copy link
Contributor

could you please mark iroha2 issues with corresponding label

@kuvaldini kuvaldini added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 4, 2021
@mversic
Copy link
Contributor Author

mversic commented Dec 4, 2021

@kuvaldini yes, I forgot. I'll try to be more careful

@mversic mversic mentioned this issue Dec 5, 2021
Closed
appetrosyan added a commit that referenced this issue Dec 6, 2021
@mversic @appetrosyan
[feature] #1675: use type instead of wrapper struct for versioned ite…
cd16272 
…ms (#1665)

* use type instead of wrapper struct for inner versioned items

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

* rename unwrap methods on versioned structures

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 8, 2021
@mversic @appetrosyan
[feature] hyperledger#1675: use type instead of wrapper struct for ve…
f6f2856 
…rsioned items (hyperledger#1665)

* use type instead of wrapper struct for inner versioned items

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

* rename unwrap methods on versioned structures

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @mversic @kuvaldini