Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concretise Errors in iroha_core #1742

Closed
appetrosyan opened this issue Dec 20, 2021 · 0 comments
Closed

Concretise Errors in iroha_core #1742

appetrosyan opened this issue Dec 20, 2021 · 0 comments
Assignees
@appetrosyan
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Dec 20, 2021 •
edited
Loading

In Iroha core, many error types were implicitly converted into eyre::Reports which replaced transaction rejection reason with Some other error happened.
@appetrosyan appetrosyan changed the title Fix errors in Iroha core Concretise Errors in iroha_core Dec 20, 2021
@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 20, 2021
@appetrosyan appetrosyan self-assigned this Dec 20, 2021
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 21, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
fd448fa 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
a510b1d 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
a73f39b 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
9936ae1 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
4a3a53c 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
705b94b 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan mentioned this issue Dec 22, 2021
Merged
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
a2c8229 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
3987dca 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
fa72457 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
4e72b26 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
5ad16d2 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
e0ffd3e 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
80c6dca 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
36aa421 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
d280626 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
d8fb3dc 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 22, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
25128dd 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 23, 2021
@appetrosyan
[fix] hyperledger#1742: Concrete errors returned in core instructions.
2139160 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue Dec 23, 2021
@appetrosyan
[fix] #1742: Concrete errors returned in core instructions. (#1744)
276ae90 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan mentioned this issue Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appetrosyan appetrosyan

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appetrosyan