Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query::Error fully typed structure #1815

Closed
s8sato opened this issue Jan 13, 2022 · 1 comment · Fixed by #1867
Closed

Make query::Error fully typed structure #1815

s8sato opened this issue Jan 13, 2022 · 1 comment · Fixed by #1867
Assignees
@s8sato
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface

Comments

@s8sato
Copy link
Contributor

s8sato commented Jan 13, 2022 •
edited
Loading

S Sato, [2022/01/13 20:27]
[In reply to Dima]
A query fails into a response 40x
whose body is UTF8 string which contains "hint".
Does it make sense to you?

Dima, [2022/01/13 20:32]
[In reply to S Sato]
Ah, I see - response body is a hint
I think it may be useful for client user to expose to him parsed error as a enum format like AssetNotFound::Domain
@s8sato s8sato added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 13, 2022
@s8sato
Copy link
Contributor Author

s8sato commented Jan 13, 2022

Ideally do the same for torii::Error ?

@s8sato s8sato self-assigned this Jan 13, 2022
@appetrosyan appetrosyan added the UI Something about the interface label Feb 9, 2022
@s8sato s8sato mentioned this issue Feb 15, 2022
Merged
@s8sato s8sato linked a pull request Feb 15, 2022 that will close this issue
[feature] #1815: Make query responses more type-structured #1867
Merged
@s8sato s8sato added the api-changes Changes in the API for client libraries label Feb 25, 2022
appetrosyan pushed a commit that referenced this issue Feb 25, 2022
@s8sato
[feature] #1815: Make query responses more type-structured (#1867)
b2a353c
@s8sato s8sato closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] #1815: Make query responses more type-structured s8sato/iroha
2 participants
@appetrosyan @s8sato