Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make running and building the smartcontract optional and only invoked provided the toolchain is installed and configured. #2215

Closed
appetrosyan opened this issue May 16, 2022 · 0 comments
Closed

Make running and building the smartcontract optional and only invoked provided the toolchain is installed and configured. #2215

appetrosyan opened this issue May 16, 2022 · 0 comments
Assignees
@appetrosyan
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

Currently every time we want to deploy anything related to the Iroha v2, we are stuck with a problem caused by the build.rs in iroha_client, that requires having the nightly toolchain installed.

As we don't use any nightly features, and the build script only requires the toolchain to build a test, I believe that the nightly requirement should be made purely optional.
@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 16, 2022
@appetrosyan appetrosyan self-assigned this May 16, 2022
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 16, 2022
@appetrosyan
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
82a5141 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan mentioned this issue May 16, 2022
Merged
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 16, 2022
@appetrosyan
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
69f1099 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 17, 2022
@appetrosyan
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
3a612d0 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 17, 2022
@appetrosyan
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
0644463 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue May 17, 2022
@appetrosyan
[fix] #2215: Make nightly-2022-04-20 optional for cargo build
4c137a1 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 17, 2022
@appetrosyan
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
1512289 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue May 18, 2022
@appetrosyan
[fix] #2215: Make nightly-2022-04-20 optional for cargo build
24f2399 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
pesterev pushed a commit to pesterev/iroha that referenced this issue May 25, 2022
@appetrosyan @pesterev
[fix] hyperledger#2215: Make nightly-2022-04-20 optional for `cargo b…
56b3613 
…uild`

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appetrosyan appetrosyan

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appetrosyan