Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Blockchain params as ISI #2399

Closed
appetrosyan opened this issue Jun 27, 2022 · 1 comment
Closed

[UI] Blockchain params as ISI #2399

appetrosyan opened this issue Jun 27, 2022 · 1 comment
Assignees
@SamHSmith @ilchu
Labels
api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Jun 27, 2022 •
edited
Loading

As per the Wiki some configuration options need to be synchronised across all peers and pass consensus. We incorrectly set these values in the config.json file, which can silently diverge across peers, giving incoherent or incomprehensible error messages.

Instead we should implement a mechanism for setting global blockchain configurations as separate from the peer-local configurations. More importantly, they need to be implemented as ISI, so that the record of changing the options can be transferred and peers attempting to validate the blockchain's history are given the full context.

In effect, all options that need to either be synchronised, pass consensus or both need to be reflected as ISI.
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha labels Jun 27, 2022
@appetrosyan appetrosyan changed the title Implement instructions to synchronise blockchain invariants Implement instructions to set blockchain parameters Jun 27, 2022
@appetrosyan appetrosyan added the question Further information is requested label Jul 6, 2022
@appetrosyan appetrosyan changed the title Implement instructions to set blockchain parameters Consider Implementing instructions to set blockchain parameters Jul 6, 2022
@Erigara Erigara self-assigned this Jul 26, 2022
@appetrosyan appetrosyan removed the question Further information is requested label Oct 11, 2022
@appetrosyan
Copy link
Contributor Author

Related to #2818

@appetrosyan appetrosyan changed the title Consider Implementing instructions to set blockchain parameters [UI] Blockchain params as ISI Oct 11, 2022
ilchu added a commit to ilchu/iroha that referenced this issue Nov 25, 2022
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
a415987 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
@ilchu ilchu mentioned this issue Nov 25, 2022
Merged
ilchu added a commit to ilchu/iroha that referenced this issue Nov 25, 2022
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
c4a4024 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Dec 28, 2022
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
a5d11e8 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
appetrosyan pushed a commit to ilchu/iroha that referenced this issue Dec 30, 2022
@ilchu @appetrosyan
[feature] hyperledger#2399: Config parameters as ISI
1c145ae 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Jan 19, 2023
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
60ad361 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Jan 19, 2023
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
7d6e173 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Jan 25, 2023
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
7850cf0 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Jan 26, 2023
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
1dfd008 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Feb 8, 2023
@ilchu
[feature] hyperledger#2399: Config parameters as ISI
57eca80 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit that referenced this issue Feb 8, 2023
@ilchu
[feature] #2399: Config parameters as ISI
31f5b2c 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamHSmith SamHSmith

@ilchu ilchu

Labels
api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SamHSmith @appetrosyan @ilchu @Erigara