Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ConfigurationProxy failure reporting #3031

Closed
ilchu opened this issue Dec 21, 2022 · 0 comments
Closed

Enhance ConfigurationProxy failure reporting #3031

ilchu opened this issue Dec 21, 2022 · 0 comments
Assignees
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST macros

Comments

@ilchu
Copy link
Contributor

ilchu commented Dec 21, 2022

With that said, we should print all of the missing fields, not just the first. Given that these errors are generated in a macro, I think there can be some reusable logic

I.e. refactor the config proxy build and/or generation routine so that it lists all the fields which did not have acceptable values that would allow it to build.

Second, make the build message more informative instead of just Proxy failed at build stage.

Finally, eprintln! the received proxy to make debugging less painful.

@ilchu ilchu added iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request good first issue Good for newcomers macros labels Dec 21, 2022
@ilchu ilchu changed the title Print all missing fields in case of proxy failure Print all missing fields in case of config proxy build failure Dec 21, 2022
@ilchu ilchu changed the title Print all missing fields in case of config proxy build failure Enhance ConfigurationProxy failure reporting Dec 21, 2022
@ilchu ilchu self-assigned this Feb 1, 2023
@appetrosyan appetrosyan assigned appetrosyan and unassigned ilchu Feb 14, 2023
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 22, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 23, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 24, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Apr 17, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Apr 19, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Apr 24, 2023
…ters

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue Apr 24, 2023
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue Jun 5, 2023
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST macros
Projects
None yet
Development

No branches or pull requests

2 participants