Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map transaction hash to block hash in wsv #3063

Closed
mversic opened this issue Jan 17, 2023 · 1 comment
Closed

Map transaction hash to block hash in wsv #3063

mversic opened this issue Jan 17, 2023 · 1 comment
Assignees
@Erigara
Labels
Chore This is a small task that can be done at any point in time and is easier than others good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should

Comments

@mversic
Copy link
Contributor

mversic commented Jan 17, 2023

I've noticed that we're storing hashes of all transactions in wsv as a DashSet<HashOf<VersionedSignedTransaction>>. Since we're doing that, I would recommend that we store a mapping DashMap<HashOf<VersionedSignedTransaction>, HashOf<VersionedCommittedBlock>> which would greatly seed up the search for a transaction in the blockchain. Currently we're searching the entire blockchain for the transaction based on the hash
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should question Further information is requested labels Jan 17, 2023
@mversic mversic added good first issue Good for newcomers Chore This is a small task that can be done at any point in time and is easier than others labels Jan 27, 2023
@appetrosyan
Copy link
Contributor

Excellent point. Don't think it's a Question though.

@appetrosyan appetrosyan removed the question Further information is requested label Jun 5, 2023
@Erigara Erigara self-assigned this Jun 14, 2023
Erigara added a commit to Erigara/iroha that referenced this issue Jun 14, 2023
@Erigara
[refactor] hyperledger#3063: Map transaction hash to block height in wsv
ed4e698 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Jun 14, 2023
Merged
5 tasks
Erigara added a commit that referenced this issue Jun 15, 2023
@Erigara
[refactor] #3063: Map transaction hash to block height in wsv
2cda8f1 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Erigara @mversic
[refactor] #3063: Map transaction hash to block height in wsv
e80f172 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
Chore This is a small task that can be done at any point in time and is easier than others good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @Erigara @mversic