-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split control flow from data processing in sumeragi #3352
Labels
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Optimization
Something isn't working as well as it should
Comments
mversic
added
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Optimization
Something isn't working as well as it should
labels
Apr 4, 2023
SamHSmith
added a commit
to SamHSmith/iroha
that referenced
this issue
Jun 26, 2023
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith
added a commit
to SamHSmith/iroha
that referenced
this issue
Jun 28, 2023
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith
added a commit
to SamHSmith/iroha
that referenced
this issue
Jul 3, 2023
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith
added a commit
to SamHSmith/iroha
that referenced
this issue
Jul 3, 2023
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith
added a commit
to SamHSmith/iroha
that referenced
this issue
Jul 6, 2023
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
appetrosyan
pushed a commit
that referenced
this issue
Jul 10, 2023
mversic
pushed a commit
that referenced
this issue
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Optimization
Something isn't working as well as it should
At the moment we have only one control flow message in
sumeragi
, namelyViewChangeSuggested
, and it is processed alongside other data messages. This is not optimal for many reasons. One of the problems is that they share the same queue which introduces a lag in the processing of control flow messages due to which under high contention(lot of gossiping, etc.) nodes can stay out of sync for prolong periods of timeAdditionally, control flow messages should also have priority in processing because some of the data messages waiting in the queue (that have arrived before the control message) could already be outdated.
This separation can be achieved with a separate queue for control flow messages or by changing the existing message queue into
PriorityQueue
where control flow messages have a higher priority than data messagesThe text was updated successfully, but these errors were encountered: