Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eyre from iroha libraries #3353

Closed
SamHSmith opened this issue Apr 4, 2023 · 0 comments
Closed

Remove eyre from iroha libraries #3353

SamHSmith opened this issue Apr 4, 2023 · 0 comments
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@SamHSmith
Copy link
Contributor

SamHSmith commented Apr 4, 2023 •
edited by mversic
Loading

Using eyre::Report is only good for errors in binaries. For libraries we should have custom error types (that implement thiserror::Error)
@SamHSmith SamHSmith added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 4, 2023
@SamHSmith SamHSmith mentioned this issue Apr 4, 2023
Merged
@mversic mversic changed the title Remove eyre from block.rs in core. Remove eyre from iroha libraries Apr 5, 2023
@Erigara Erigara self-assigned this Jun 15, 2023
Erigara added a commit to Erigara/iroha that referenced this issue Jun 16, 2023
@Erigara
[refactor] hyperledger#3353: Remove eyre from block.rs
2ba8ff5 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Jun 16, 2023
Merged
5 tasks
appetrosyan pushed a commit to Erigara/iroha that referenced this issue Jun 19, 2023
@Erigara @appetrosyan
[refactor] hyperledger#3353: Remove eyre from block.rs
4afff50 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
appetrosyan pushed a commit that referenced this issue Jun 19, 2023
@Erigara @appetrosyan
[refactor] #3353: Remove eyre from block.rs
4183b1b 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Erigara @mversic
[refactor] #3353: Remove eyre from block.rs
1e09ce1 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SamHSmith @appetrosyan @Erigara