-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Kagami fails to generate a validator when runs outside of the repo dir #3473
Labels
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
Comments
0x009922
added
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
May 12, 2023
0x009922
changed the title
[BUG] Kagami could not generate validator when run outside of the repo dir
[BUG] Kagami fails to generate a validator when runs outside of the repo dir
May 12, 2023
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 15, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 15, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 15, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
3 tasks
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 21, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 21, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 26, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jun 26, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jul 7, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jul 7, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jul 10, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu
added a commit
to ilchu/iroha
that referenced
this issue
Jul 12, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
appetrosyan
pushed a commit
to ilchu/iroha
that referenced
this issue
Jul 12, 2023
… `iroha` dir Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
appetrosyan
pushed a commit
that referenced
this issue
Jul 12, 2023
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Should be addressed by #3748. |
mversic
pushed a commit
that referenced
this issue
Oct 17, 2023
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
OS and Environment
macOS 13.2.1 (22D68)
GIT commit hash
d7e054d
Minimum working example / Steps to reproduce
Create a directory:
Install
kagami
binary there:Run compiled kagami:
Actual result
Expected result
Expected to get the compiled wasm blob.
Logs in JSON format
N/A
Who can help to reproduce?
No response
Notes
Kagami relies to be always executed in the root of the repo:
iroha/tools/kagami/src/main.rs
Lines 815 to 826 in d7e054d
I don't think this is correct - Kagami should be a standalone, self-contained binary with "all batteries included". So, the wasm binary should be inlined into the binary itself.
This functionality is essential for #2373, which I am working on now. Thus, I assign this issue to myself.
The text was updated successfully, but these errors were encountered: