Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix validator path schema repr #3552

Closed
mversic opened this issue Jun 1, 2023 · 1 comment
Closed

[BUG] Fix validator path schema repr #3552

mversic opened this issue Jun 1, 2023 · 1 comment
Assignees
@mversic @timofeevmd
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@mversic
Copy link
Contributor

mversic commented Jun 1, 2023 •
edited
Loading

Instead of

"ValidatorPath": {
  "Struct": [
    {
      "name": "validator_relative_path",
      "type": "String"
    }
  ]
}

should be:

"ValidatorPath": {
  "Struct": [
    {
      "name": "validator_path",
      "type": "String"
    }
  ]
}

Originally posted by @arndey
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 1, 2023
@mversic mversic self-assigned this Jun 1, 2023
mversic added a commit to mversic/iroha that referenced this issue Jun 1, 2023
@mversic
[fix] hyperledger#3552: Fix validator path schema repr
e8c8882 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic
Copy link
Contributor Author

mversic commented Jun 1, 2023

I have removed one level of nesting and settled for:

"ValidatorPath": "String"

@mversic mversic mentioned this issue Jun 1, 2023
Merged
5 tasks
appetrosyan pushed a commit that referenced this issue Jun 1, 2023
@mversic @appetrosyan
[fix] #3552: Fix validator path schema repr
dd730f9 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@mversic @appetrosyan
[fix] #3552: Fix validator path schema repr
851cab0 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@timofeevmd timofeevmd self-assigned this Jun 5, 2023
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Jun 5, 2023
mversic added a commit that referenced this issue Oct 17, 2023
@mversic
[fix] #3552: Fix validator path schema repr
6810649 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

@timofeevmd timofeevmd

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mversic @timofeevmd