Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to build Kagami with cargo install #3603

Closed
Tracked by #2373
timofeevmd opened this issue Jun 13, 2023 · 2 comments
Closed
Tracked by #2373

[BUG] Unable to build Kagami with cargo install #3603

timofeevmd opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@timofeevmd
Copy link
Contributor

OS and Environment

MacOS 13.3

GIT commit hash

2f371c9

Minimum working example / Steps to reproduce

When trying to make a cargo install from the root directory, the process crashes with an error

cargo install --git https://github.com/hyperledger/iroha.git \
   --all-features \
   --rev 2f371c97 \
   --root ./cargo-install-root \
   kagami
cargo install --path ../tools/kagami \
   --all-features \
   --root ./cargo-install-root \
   kagami

Error message

error[E0616]: field `definition_id` of struct `iroha_data_model::permission::PermissionToken` is private

Actual result

Error message

error[E0616]: field `definition_id` of struct `iroha_data_model::permission::PermissionToken` is private
    --> tools/kagami/src/main.rs:365:67
     |
365 | RegisterBox::new(PermissionTokenDefinition::new(token.definition_id.clone()));
     |                                                                                                    ^^^^^^^^^^^^^ private field
     |
help: a method `definition_id` also exists, call it with parentheses
     |
365 | RegisterBox::new(PermissionTokenDefinition::new(token.definition_id().clone()));

Expected result

deploy successfully

Logs in JSON format

unfortunately I have nothing to add here

Who can help to reproduce?

@timofeevmd

Notes

No response

@timofeevmd timofeevmd added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jun 13, 2023
@0x009922 0x009922 changed the title [BUG] When installing kakgami, cargo install build crashes [BUG] Unable to build Kagami with cargo install Jun 14, 2023
@0x009922
Copy link
Contributor

0x009922 commented Aug 7, 2023

@timofeevmd, could you verify it on the latest iroha2-dev?

@0x009922
Copy link
Contributor

With @appetrosyan and @ilchu, we decided that we don't have a goal to make Kagami runnable outside of the repo root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

2 participants