-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insure transaction atomicity #3627
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
question
Further information is requested
Comments
Erigara
changed the title
Insure that isi doesn't change wsv in case of rejection.
Insure that isi doesn't change wsv in case of error
Jun 20, 2023
Currently isi like |
Also |
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 21, 2023
There is two ways to achieve atomic transactions:
|
Erigara
changed the title
Insure that isi doesn't change wsv in case of error
Insure transaction atomicity
Jun 21, 2023
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 22, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 22, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
5 tasks
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 23, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 26, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 26, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Jun 26, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
that referenced
this issue
Jun 26, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
that referenced
this issue
Oct 17, 2023
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
question
Further information is requested
As part of implementing runtime validator RFC (#3615) we need to make sure that if isi returns error no changes was made to wsv.
Some guardrails could be added to ensure that
hash(wsv_before) == hash(wsv_after_error)
.The text was updated successfully, but these errors were encountered: