Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MST aggregation from iroha #4229

Closed
mversic opened this issue Jan 24, 2024 · 3 comments
Closed

remove MST aggregation from iroha #4229

mversic opened this issue Jan 24, 2024 · 3 comments
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Jan 24, 2024

I think we should remove aggregation of MST signatures out of Iroha. Transaction signing should happen outside Iroha and only after all signatures have been collected should it be submitted to Iroha

This would also mean that we should remove pending_transactions endpoint

@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Jan 24, 2024
@0x009922
Copy link
Contributor

0x009922 commented Feb 5, 2024

If this issue is closed as not planned and we decide not to remove pending_transactions endpoint, we should not forget to document it in the Torii reference.

@mversic mversic removed the question Further information is requested label Feb 5, 2024
@mversic
Copy link
Contributor Author

mversic commented Feb 7, 2024

also remove hash_of_payload from SignedTransaction

Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 20, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
AlexStroke pushed a commit to Stukalov-A-M/iroha that referenced this issue Feb 21, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
@s8sato
Copy link
Contributor

s8sato commented Feb 22, 2024

I don't think it's too late to remove one feature after coming up with an alternative implementation.

I agree with stopping transactions pending in the queue because, if my memory is correct, at some point the queue became a performance bottleneck and its simplification might help.
However, collecting signatures outside Iroha seems to predict client-to-client communication or another server that presents transaction candidates and collects votes, about which I have no idea.

Instead, now that we have triggers, I think it is possible to implement multi-signature transaction proposal as a trigger registration, and approval for it as a voting instruction targeting the trigger. This approach is similar to that of Polkadot.
In this way,

  • since candidates are committed, they will be visible via explorer as usual
  • every transaction has one signature, which might save transaction size

Anyway, multi-signature is a common feature and we'd better consider alternatives

VAmuzing pushed a commit to Stukalov-A-M/iroha that referenced this issue Feb 23, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 26, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 26, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 26, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 28, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 29, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 29, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 29, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 29, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M added a commit that referenced this issue Feb 29, 2024
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

4 participants