Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke PermissionTokens on Upgrade<Executor> #4331

Closed
mversic opened this issue Feb 27, 2024 · 1 comment · Fixed by #4503
Closed

Revoke PermissionTokens on Upgrade<Executor> #4331

mversic opened this issue Feb 27, 2024 · 1 comment · Fixed by #4503
Assignees
@dima74 @timofeevmd
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Security This issue asks for improved security

Comments

@mversic
Copy link
Contributor

mversic commented Feb 27, 2024 •
edited
Loading

We should make sure that executor upgrade doesn't leave the system in an inconsistent state. If executor migration removes a certain PermissionToken that is still referenced by an account or a role the corresponding token should be revoked. This should be implemented in iroha_core
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested Security This issue asks for improved security labels Feb 27, 2024
@mversic mversic changed the title Forbid Upgrade<Executor> if there are discrepancies in PermissionTokens/Parameters Revoke PermissionTokens on Upgrade<Executor> Apr 17, 2024
@mversic mversic removed the question Further information is requested label Apr 17, 2024
@mversic
Copy link
Contributor Author

mversic commented Apr 17, 2024

We would want to make the same case for parameters after #3901

@dima74 dima74 self-assigned this Apr 19, 2024
dima74 added a commit to dima74/iroha that referenced this issue Apr 23, 2024
@dima74
[fix] hyperledger#4331: Revoke removed PermissionTokens on `Upgrade…
d701f63 
…<Executor>`

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 mentioned this issue Apr 23, 2024
Merged
5 tasks
dima74 added a commit to dima74/iroha that referenced this issue Apr 24, 2024
@dima74
[fix] hyperledger#4331: Revoke removed PermissionTokens on `Upgrade…
e274741 
…<Executor>`

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic pushed a commit to dima74/iroha that referenced this issue May 1, 2024
@dima74 @mversic
[fix] hyperledger#4331: Revoke removed PermissionTokens on `Upgrade…
36bbcbd 
…<Executor>`

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic pushed a commit that referenced this issue May 1, 2024
@dima74
[fix] #4331: Revoke removed PermissionTokens on Upgrade<Executor> (…
0a936c3 
…#4503)

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 reopened this May 2, 2024
@timofeevmd timofeevmd self-assigned this May 14, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

@timofeevmd timofeevmd

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] #4331: Revoke removed PermissionTokens on Upgrade<Executor> dima74/iroha
3 participants
@dima74 @mversic @timofeevmd