[fix] #1801: fix schema generation for HashOf, SignatureOf #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
appetrosyan,
KalitaAlexey and
s8sato
as code owners
github-actions
bot
added
the
iroha2-dev
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1804 +/- ##
==============================================
+ Coverage 77.22% 78.75% +1.53%
==============================================
Files 137 137
Lines 21145 21166 +21
==============================================
+ Hits 16329 16670 +341
+ Misses 4816 4496 -320
Continue to review full report at Codecov.
|
mversic
commented
Jan 11, 2022
| @@ -84,13 +84,6 @@ pub struct RemoveKeyValueBox { | |||
| pub key: EvaluatesTo<Name>, | |||
| } | |||
|
|
|||
| /// Sized structure for all possible Sets. | |||
| #[derive(Debug, Clone, Serialize, Deserialize, Encode, Decode, PartialEq, Eq, IntoSchema)] | |||
| pub struct SetBox { | |||
There was a problem hiding this comment.
Two uses total. Here and in Schema. I would ask the library developers if they use it. If they don't I'd get rid of it.
mversic
force-pushed
the
missing_schemas
branch
from
96332b3
to
07b5315
Compare
appetrosyan
reviewed
Jan 11, 2022
| @@ -84,13 +84,6 @@ pub struct RemoveKeyValueBox { | |||
| pub key: EvaluatesTo<Name>, | |||
| } | |||
|
|
|||
| /// Sized structure for all possible Sets. | |||
| #[derive(Debug, Clone, Serialize, Deserialize, Encode, Decode, PartialEq, Eq, IntoSchema)] | |||
| pub struct SetBox { | |||
There was a problem hiding this comment.
Two uses total. Here and in Schema. I would ask the library developers if they use it. If they don't I'd get rid of it.
mversic
force-pushed
the
missing_schemas
branch
from
07b5315
to
ec1bf05
Compare
…schemas are missing Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
missing_schemas
branch
from
ec1bf05
to
3dbcb76
Compare
s8sato
approved these changes
Jan 12, 2022
appetrosyan
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…schemas are missing
Signed-off-by: Marin Veršić marin.versic101@gmail.com
Description of the Change
HashOf,SignatureOfIssue
Closes #1801
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]
IntoSchemamacro can be improved to account forPhantomDatafields. Maybe in the future