Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1902: Bare metal 4-peer setup script. #1923

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

appetrosyan
Copy link
Contributor

@appetrosyan appetrosyan commented Feb 18, 2022

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

Refactored scripts to be more self-contained and flexible for use in GitHub actions.

Added a version of setup_test_env.sh that does not require docker-compose and uses the debug build of Iroha.

Issue

Closes #1902.

Benefits

Can run tests using live iroha peers without use of Docker. Creates pathway to resolve #1726

Possible Drawbacks

More logic relegated to bash.

TODO

Cleanup.

Test on other configurations.

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1923 (a09bce3) into iroha2-dev (e0eda1e) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1923      +/-   ##
==============================================
+ Coverage       78.20%   78.25%   +0.05%     
==============================================
  Files             164      164              
  Lines           22528    22528              
==============================================
+ Hits            17618    17630      +12     
+ Misses           4910     4898      -12     
Impacted Files Coverage Δ
p2p/src/peer.rs 82.26% <0.00%> (ø)
data_model/src/expression.rs 71.04% <0.00%> (+0.26%) ⬆️
p2p/tests/p2p.rs 99.17% <0.00%> (+1.23%) ⬆️
core/src/block_sync.rs 89.93% <0.00%> (+1.25%) ⬆️
crypto/src/signature.rs 86.77% <0.00%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eda1e...a09bce3. Read the comment docs.

@appetrosyan appetrosyan force-pushed the i2-bare-metal branch 4 times, most recently from 5ff96dd to a06d627 Compare February 20, 2022 16:01
@appetrosyan appetrosyan marked this pull request as ready for review February 20, 2022 16:14
scripts/API/java.sh Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
scripts/setup_test_env.sh Outdated Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the i2-bare-metal branch 2 times, most recently from f710573 to d94d258 Compare February 21, 2022 09:37
@mversic mversic self-requested a review February 21, 2022 09:39
mversic
mversic previously approved these changes Feb 21, 2022
@appetrosyan appetrosyan added CI Enhancement New feature or request labels Feb 21, 2022
Copy link
Contributor

@s8sato s8sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that peers share the only storage (./blocks) ?

scripts/setup_test_env.sh Outdated Show resolved Hide resolved
scripts/API/java.sh Show resolved Hide resolved
scripts/API/java.sh Outdated Show resolved Hide resolved
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan merged commit f25ca85 into hyperledger:iroha2-dev Feb 22, 2022
@appetrosyan appetrosyan deleted the i2-bare-metal branch February 22, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants