Feature/proposal request optimization v2 #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
…posal_request_optimization_v2
iceseer
force-pushed
the
feature/proposal_request_optimization_v2
branch
from
1155f8a
to
44accbb
Compare
…equest_optimization_v2
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
feature/proposal_request_optimization_v2
branch
from
3e637bf
to
9176378
Compare
iceseer
force-pushed
the
feature/proposal_request_optimization_v2
branch
from
6893bc7
to
e647289
Compare
iceseer
force-pushed
the
feature/proposal_request_optimization_v2
branch
from
e647289
to
2ec9855
Compare
iceseer
force-pushed
the
feature/proposal_request_optimization_v2
branch
from
0bce3b0
to
4954fa4
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
Alexey-N-Chernyshov
approved these changes
Apr 7, 2022
iceseer
added a commit
that referenced
this pull request
Apr 8, 2022
* bloom filter Signed-off-by: iceseer <iceseer@gmail.com> Signed-off-by: Alexander Lednev <57529355+iceseer@users.noreply.github.com> * transport with BF support Signed-off-by: iceseer <iceseer@gmail.com> Signed-off-by: Alexander Lednev <57529355+iceseer@users.noreply.github.com> * txs diff complete Signed-off-by: iceseer <iceseer@gmail.com> Signed-off-by: Alexander Lednev <57529355+iceseer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Proposal traffic optimization example:
Given 2 Nodes(A and B).
When B is used as OS and proposal creator. Than A should make a proposal request.
Before this request A makes a local proposal(PA). And saves it's batches hashes in Bloom-filter(BA).
Than A makes a proposal request to B with round data and BA.
B receives request and makes it's local proposal PB with Bloom-filter BB.
Knowing BA node B can determine the batches which are not present in PA. It forms response with this batches, BB and hash of PB.
A received the response using BB can determine batches which it has in PA but not present in PB. A repacks it local proposal with new batches from response and batches that remained in PA. After that A compares the hash of new PA with hash from PB. If they are equal it proceed processing. If not, A sends a request with empty BA and takes a full proposal in response than can be processed, but it is a very rare situation(about 0.01 % cases).
Since Bloom-filter can be false positive. We use result hash comparison and full proposal request mechanics.