[fix] #2111: Remove roles feature
#2134
Merged
+23
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
requested review from
s8sato,
appetrosyan,
mversic and
SamHSmith
as code owners
mversic
approved these changes
Apr 21, 2022
|
could there be a reason why somebody wouldn't want this feature? |
SamHSmith
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removed
rolesfeature from everywhere to provide (de-)serialization stabilityIssue
rolesfeature flag indata_modelcauses serialization disparity #2111Benefits
No more pain and hidden bug caused by roles feature
Possible Drawbacks
If we will need it back it's can be tricky to find all places where it should be conditional compiled or something like that