Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] #2153: Fix #2154 #2166

Merged
merged 2 commits into from
May 5, 2022
Merged

[ci] #2153: Fix #2154 #2166

merged 2 commits into from
May 5, 2022

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Apr 29, 2022

Description of the Change

  • Add a step to add llvm-tools-preview component

Issue

Benefits

Possible Drawbacks

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2166 (410b8b2) into iroha2-dev (2a94dba) will decrease coverage by 0.09%.
The diff coverage is 72.86%.

❗ Current head 410b8b2 differs from pull request most recent head c2fddd2. Consider uploading reports for the commit c2fddd2 to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #2166      +/-   ##
==============================================
- Coverage       77.27%   77.17%   -0.10%     
==============================================
  Files             176      182       +6     
  Lines           24216    25916    +1700     
==============================================
+ Hits            18713    20001    +1288     
- Misses           5503     5915     +412     
Impacted Files Coverage Δ
client/benches/tps/lib.rs 0.00% <0.00%> (ø)
client/benches/tps/oneshot.rs 0.00% <0.00%> (ø)
client/examples/million_accounts_genesis.rs 0.00% <0.00%> (ø)
client/src/lib.rs 100.00% <ø> (ø)
client/tests/integration/connected_peers.rs 100.00% <ø> (+10.00%) ⬆️
...lient/tests/integration/multiple_blocks_created.rs 0.00% <0.00%> (ø)
client/tests/integration/unregister_peer.rs 0.00% <0.00%> (-100.00%) ⬇️
client/tests/integration/unstable_network.rs 0.00% <0.00%> (ø)
client_cli/src/main.rs 0.30% <0.00%> (-0.03%) ⬇️
config/src/lib.rs 16.66% <ø> (ø)
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067dfd9...c2fddd2. Read the comment docs.

@s8sato
Copy link
Contributor Author

s8sato commented Apr 29, 2022

Closed because the coverage contains target/debug/build for some reason and has dropped to about 70% from previous about 78%

@s8sato s8sato closed this Apr 29, 2022
@s8sato s8sato reopened this Apr 29, 2022
@s8sato
Copy link
Contributor Author

s8sato commented Apr 29, 2022

Resolved the coverage regression

s8sato added 2 commits May 5, 2022 17:15
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@appetrosyan appetrosyan merged commit 8df1b4c into hyperledger:iroha2-dev May 5, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants