[fix] #2232: Make Iroha print meaningful message when genesis has too many isi #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjentix
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI and
outoftardis
as code owners
github-actions
bot
added
the
iroha2-dev
appetrosyan
added
Enhancement
appetrosyan
reviewed
May 20, 2022
| @@ -96,11 +96,15 @@ where | |||
| /// To make `Iroha` peer work all actors should be started first. | |||
| /// After that moment it you can start it with listening to torii events. | |||
| /// | |||
| /// # Side effect | |||
appetrosyan
reviewed
May 20, 2022
appetrosyan
reviewed
May 20, 2022
| rt.block_on(peer.start_with_config_permissions_dir( | ||
| configuration.clone(), | ||
| GenesisNetwork::test(true), | ||
| AllowAll, |
There was a problem hiding this comment.
Refers to this. The permissions need to be specified inside the genesis block, not hard-coded in the init process.
|
Need to update the tests too |
Arjentix
force-pushed
the
fix_genesis_too_many_isi
branch
3 times, most recently
from
24a7186
to
82567fc
Compare
Arjentix
commented
May 20, 2022
| @@ -213,7 +213,7 @@ struct QueryResponseTest { | |||
|
|
|||
| #[allow(variant_size_differences)] | |||
| enum QueryResponseBody { | |||
| Ok(VersionedQueryResult), | |||
| Ok(Box<VersionedQueryResult>), | |||
There was a problem hiding this comment.
After rebase clippy was warning me about very different variant sizes, so I have to Box it
There was a problem hiding this comment.
consider removing allow.
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2239 +/- ##
==============================================
+ Coverage 63.74% 63.82% +0.08%
==============================================
Files 127 127
Lines 23581 23592 +11
==============================================
+ Hits 15031 15058 +27
+ Misses 8550 8534 -16
Continue to review full report at Codecov.
|
s8sato
approved these changes
May 20, 2022
appetrosyan
approved these changes
May 20, 2022
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
force-pushed
the
fix_genesis_too_many_isi
branch
from
82567fc
to
c206266
Compare
pesterev
pushed a commit
to pesterev/iroha
that referenced
this pull request
May 25, 2022
…sis has too many isi (hyperledger#2239) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniil Polyakov arjentix@gmail.com
Description of the Change
Issue
isi, Iroha prints meaningless message #2232Peerin test_network #2238Benefits
Now users will get more meaningful message when they have too many instructions inside transactions
Possible Drawbacks
None
Usage Examples or Tests
You can take a big genesis from issue description and run Iroha with it to check this out.
I don't think I can write a test for it. This is UI-specific problem