Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] #2564: Kagami algorithm options #2568

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Jul 29, 2022

Description of the Change

Adds options for Kagami tool crypto algorithms:

  • ed25519
  • secp256k1
  • bls_normal
  • bls_small

Issue

Resolves #2564

Benefits

Kagami tool's usability will improve

Possible Drawbacks

None

Usage Examples or Tests [optional]

cargo run --bin kagami  -- crypto --help

Alternate Designs [optional]

None, this is simply an update to the Kagami docs

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2568 (839d583) into iroha2-dev (a16d9c3) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

❗ Current head 839d583 differs from pull request most recent head 031aae7. Consider uploading reports for the commit 031aae7 to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #2568      +/-   ##
==============================================
- Coverage       67.61%   66.99%   -0.62%     
==============================================
  Files             140      155      +15     
  Lines           26173    28009    +1836     
==============================================
+ Hits            17696    18764    +1068     
- Misses           8477     9245     +768     
Impacted Files Coverage Δ
tools/kagami/src/main.rs 0.46% <0.00%> (ø)
data_model/src/expression.rs 47.04% <0.00%> (-22.90%) ⬇️
data_model/src/events/data/events.rs 25.00% <0.00%> (-17.71%) ⬇️
core/src/lib.rs 83.33% <0.00%> (-16.67%) ⬇️
core/src/smartcontracts/isi/block.rs 88.88% <0.00%> (-11.12%) ⬇️
core/src/smartcontracts/isi/permissions/roles.rs 53.22% <0.00%> (-7.31%) ⬇️
data_model/src/name.rs 87.60% <0.00%> (-6.31%) ⬇️
data_model/src/trigger/set.rs 39.08% <0.00%> (-5.57%) ⬇️
data_model/src/query.rs 37.20% <0.00%> (-2.95%) ⬇️
core/src/block_sync.rs 41.66% <0.00%> (-2.85%) ⬇️
... and 108 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@6r1d 6r1d changed the title Kagami algorithm options [feature] #2564: Kagami algorithm options Jul 29, 2022
@appetrosyan appetrosyan changed the title [feature] #2564: Kagami algorithm options [docs] #2564: Kagami algorithm options Jul 29, 2022
appetrosyan
appetrosyan previously approved these changes Jul 29, 2022
@6r1d 6r1d changed the title [docs] #2564: Kagami algorithm options [documentation] #2564: Kagami algorithm options Jul 29, 2022
outoftardis
outoftardis previously approved these changes Aug 1, 2022
tools/kagami/src/main.rs Outdated Show resolved Hide resolved
@6r1d 6r1d dismissed stale reviews from outoftardis and appetrosyan via fd71de0 August 1, 2022 06:28
@6r1d 6r1d force-pushed the kagami_doc_fix branch 2 times, most recently from ea36a0c to 35573dd Compare August 1, 2022 06:41
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 6r1d <vic.6r1d@gmail.com>
@appetrosyan appetrosyan merged commit b8fc0c6 into hyperledger:iroha2-dev Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants