-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation] #2564: Kagami algorithm options #2568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6r1d
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
July 29, 2022 11:58
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2568 +/- ##
==============================================
- Coverage 67.61% 66.99% -0.62%
==============================================
Files 140 155 +15
Lines 26173 28009 +1836
==============================================
+ Hits 17696 18764 +1068
- Misses 8477 9245 +768
Help us with your feedback. Take ten seconds to tell us how you rate us. |
6r1d
changed the title
Kagami algorithm options
[feature] #2564: Kagami algorithm options
Jul 29, 2022
appetrosyan
changed the title
[feature] #2564: Kagami algorithm options
[docs] #2564: Kagami algorithm options
Jul 29, 2022
appetrosyan
previously approved these changes
Jul 29, 2022
6r1d
changed the title
[docs] #2564: Kagami algorithm options
[documentation] #2564: Kagami algorithm options
Jul 29, 2022
outoftardis
previously approved these changes
Aug 1, 2022
6r1d
force-pushed
the
kagami_doc_fix
branch
2 times, most recently
from
August 1, 2022 06:41
ea36a0c
to
35573dd
Compare
appetrosyan
approved these changes
Aug 1, 2022
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: 6r1d <vic.6r1d@gmail.com>
appetrosyan
force-pushed
the
kagami_doc_fix
branch
from
August 1, 2022 06:51
35573dd
to
031aae7
Compare
outoftardis
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds options for Kagami tool crypto algorithms:
ed25519
secp256k1
bls_normal
bls_small
Issue
Resolves #2564
Benefits
Kagami tool's usability will improve
Possible Drawbacks
None
Usage Examples or Tests [optional]
Alternate Designs [optional]
None, this is simply an update to the Kagami docs