Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/ Adding a Sitemap #313

Closed
wants to merge 6 commits into from
Closed

Doc/ Adding a Sitemap #313

wants to merge 6 commits into from

Conversation

LiraLemur
Copy link
Contributor

Description of the Change

Sitemap is being submitted, so google's crawlers could reindex pages.

Benefits

Better SEO

Possible Drawbacks

Will need to be updated when we update the docs. Maybe it would be better to have some sort of an automatic generator in the long run.

LiraLemur and others added 3 commits November 19, 2019 18:32
Signed-off-by: Sara <lira.lemur@gmail.com>
Signed-off-by: Sara <lira.lemur@gmail.com>

Co-Authored-By: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Sara <lira.lemur@gmail.com>
Copy link
Contributor

@lebdron lebdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sitemap would be updated after #310 , maybe merge it first?

@LiraLemur
Copy link
Contributor Author

@lebdron that makes sense
Let's at least leave this PR as a placeholder, I'll commit the new version after we merge #310

Copy link
Contributor

@lebdron lebdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to look into custom build steps in readthedocs, so that this file is always up-to-date.

Copy link
Contributor

@MBoldyrev MBoldyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we should have a separate storage for generated documentation files.

@lebdron
Copy link
Contributor

lebdron commented Jun 4, 2020

Please reopen this pull request when there will be an agreement on the solution. Did not save the branch because this should be generated. Created task https://jira.hyperledger.org/browse/IR-755

@lebdron lebdron closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants