Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: fix Docker image build on Linux for master branch #317

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

lebdron
Copy link
Contributor

@lebdron lebdron commented Dec 7, 2019

Description of the Change

Docker build could have failed when Dockerfile was changed and committed to master branch because the new Dockerfile was compared to itself instead of previous version.
https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/master/218/consoleText

Benefits

Successful master build on Dockerfile changes

Possible Drawbacks

None

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@BulatSaif
Copy link
Contributor

Mater is build and push every time, referenceBranchOrCommit is used just to decide should we use docker cache while building.

@lebdron
Copy link
Contributor Author

lebdron commented Dec 9, 2019

@BulatSaif Yes, and cache is used incorrectly when triggered by a commit in master branch.

Copy link
Contributor

@kogeler kogeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@lebdron lebdron merged commit dc920c9 into hyperledger:master Dec 13, 2019
@lebdron lebdron deleted the fix/jenkins-linux-master-docker branch December 13, 2019 14:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants