-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #4140: Fix registration of new peer #4142
Merged
mversic
merged 2 commits into
hyperledger:iroha2-dev
from
mversic:fix_peer_registration
Dec 14, 2023
Merged
[fix] #4140: Fix registration of new peer #4142
mversic
merged 2 commits into
hyperledger:iroha2-dev
from
mversic:fix_peer_registration
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
December 12, 2023 16:46
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Dec 12, 2023
mversic
force-pushed
the
fix_peer_registration
branch
from
December 12, 2023 16:46
cb60164
to
2500149
Compare
Pull Request Test Coverage Report for Build 7193927722
💛 - Coveralls |
mversic
force-pushed
the
fix_peer_registration
branch
3 times, most recently
from
December 12, 2023 18:08
f93c3d5
to
06bd388
Compare
mversic
force-pushed
the
fix_peer_registration
branch
9 times, most recently
from
December 13, 2023 08:50
ef697c4
to
cd810b7
Compare
Erigara
reviewed
Dec 13, 2023
I wounder how we should deal with more general case when whole topology changed. Step by step:
|
good point. We should discuss the best solution in a separate ticket. Created #4145 |
mversic
force-pushed
the
fix_peer_registration
branch
3 times, most recently
from
December 13, 2023 10:19
c5fa890
to
c103829
Compare
mversic
force-pushed
the
fix_peer_registration
branch
from
December 13, 2023 10:30
c103829
to
2def11f
Compare
Erigara
previously approved these changes
Dec 13, 2023
mversic
force-pushed
the
fix_peer_registration
branch
4 times, most recently
from
December 13, 2023 16:05
74ed882
to
8c10072
Compare
mversic
commented
Dec 13, 2023
mversic
force-pushed
the
fix_peer_registration
branch
3 times, most recently
from
December 14, 2023 09:00
b881c14
to
87b893e
Compare
Erigara
reviewed
Dec 14, 2023
mversic
force-pushed
the
fix_peer_registration
branch
from
December 14, 2023 10:25
87b893e
to
5f83e2c
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
fix_peer_registration
branch
from
December 14, 2023 11:02
5f83e2c
to
4bf47f6
Compare
VAmuzing
reviewed
Dec 14, 2023
Erigara
approved these changes
Dec 14, 2023
VAmuzing
approved these changes
Dec 14, 2023
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com> Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #4140
Benefits
Checklist
CONTRIBUTING.md