Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4277: Infallible key pair generation #4283

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Arjentix
Copy link
Contributor

Linked issue

Benefits

Less useless error-handling

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality crypto labels Feb 15, 2024
@Arjentix Arjentix self-assigned this Feb 15, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7917722012

Details

  • -4 of 102 (96.08%) changed or added relevant lines in 17 files are covered.
  • 1258 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/samples.rs 0 1 0.0%
tools/kagami/src/genesis.rs 0 1 0.0%
core/test_network/src/lib.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/query/store.rs 1 73.2%
core/src/smartcontracts/isi/mod.rs 8 76.49%
data_model/src/predicate.rs 9 86.8%
core/src/smartcontracts/isi/tx.rs 13 66.67%
crypto/src/kex/x25519.rs 14 66.1%
smart_contract/executor/derive/src/default.rs 15 0.0%
p2p/src/peer.rs 16 0.0%
core/src/wsv.rs 17 52.2%
core/src/queue.rs 18 93.52%
core/src/tx.rs 26 53.18%
Totals Coverage Status
Change from base Build 7884695009: -0.05%
Covered Lines: 22741
Relevant Lines: 40079

💛 - Coveralls

@Erigara Erigara self-assigned this Feb 15, 2024
@mversic mversic merged commit 0f83d26 into hyperledger:iroha2-dev Feb 16, 2024
12 of 13 checks passed
@Arjentix Arjentix deleted the infallible_key_generation branch February 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants