Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Add method to define parameter in executor migrate entrypoint #4513

Closed

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Apr 25, 2024

Description

  • Added method add_parameter which can be called from executor (in migrate entrypoint) to define new executor parameter
  • Added test which demonstrates how executor can use it, as suggested here
  • Note that this PR was mostly implemented before discussion in dynamic parameter value #4352, so potentially this should be implemented differently. E.g. if it will be decided to store executor parameters in Domain::metadata, then there will be no need for add_parameter method since executor parameter will be defined using SetKeyValue ISI
  • Note that I didn't removed NewParameter ISI since it is currently used to define chain-wide parameters (for wasm engine and sumeragi), and potentially chain-wide parameters should be defined/stored differently as discussed in dynamic parameter value #4352 (comment)

Linked issue

Closes #3901
Related: #4352
Related: #4310

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

…executor `migrate` entrypoint

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@github-actions github-actions bot added Refactor Improvement to overall code quality iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 25, 2024
@mversic
Copy link
Contributor

mversic commented May 20, 2024

superseeded by #4597

@mversic mversic closed this May 20, 2024
@dima74 dima74 deleted the move-new-parameter-to-executor branch June 13, 2024 08:24
Copy link

github-actions bot commented Jul 26, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[refactor]: Add method to define parameter in executor `migrate` entrypoint". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@AlexStroke AlexStroke changed the title [refactor] #3901: Add method to define parameter in executor migrate entrypoint [refactor]: Add method to define parameter in executor migrate entrypoint Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] Move NewParameter into Executor
2 participants