refactor: Make SignedBlock immutable
#4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
mversic
reviewed
May 20, 2024
mversic
reviewed
May 20, 2024
dima74
force-pushed
the
diralik/immutable-signed-block
branch
from
43c0ed3
to
3d11289
Compare
Erigara
previously approved these changes
May 20, 2024
mversic
previously approved these changes
May 20, 2024
mversic
force-pushed
the
diralik/immutable-signed-block
branch
from
3d11289
to
2920cd4
Compare
|
your commit is not signed |
dima74
force-pushed
the
diralik/immutable-signed-block
branch
from
2920cd4
to
08b509e
Compare
Fixed |
mversic
approved these changes
May 20, 2024
Erigara
approved these changes
May 20, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic
force-pushed
the
diralik/immutable-signed-block
branch
from
08b509e
to
ce186cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I understand, the problem is that
payloadofSignedBlockcan be modified, which will result in invalidSignedBlock(inconsistentpayloadandsignatures). Currentlypayloadis modified only in tests. I madepayloadprivate and changed such tests to create new block instead of modifying existing one.Linked issue
Closes #4224
Benefits
Checklist
CONTRIBUTING.md