fix: add missing mathematical operations to Numeric
#4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
nxsaken
reviewed
Aug 14, 2024
mversic
force-pushed
the
numeric_methods
branch
2 times, most recently
from
42e3180
to
1e816f8
Compare
dima74
reviewed
Aug 15, 2024
mversic
force-pushed
the
numeric_methods
branch
3 times, most recently
from
60a5e37
to
5a21b5a
Compare
dima74
approved these changes
Aug 15, 2024
nxsaken
approved these changes
Aug 15, 2024
mversic
force-pushed
the
numeric_methods
branch
from
5a21b5a
to
8ea9ddf
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
nxsaken
force-pushed
the
numeric_methods
branch
from
8ea9ddf
to
7a319d5
Compare
mversic
added a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Numericis missing some mathematical operations and it's not possible to use itChecklist
CONTRIBUTING.md.