Bump anchor and other dependencies #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 87.36% 87.41% +0.05%
==========================================
Files 133 133
Lines 64125 64130 +5
==========================================
+ Hits 56021 56060 +39
+ Misses 8104 8070 -34
|
seanyoung
force-pushed
the
anchor
branch
2 times, most recently
from
75a7ee3
to
0740817
Compare
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Sean Young <sean@mess.org>
seanyoung
commented
Oct 19, 2023
| @@ -367,6 +367,9 @@ fn idltype_to_solidity(ty: &IdlType, ty_names: &[(String, String)]) -> Result<St | |||
| Ok(ty) => Ok(format!("{ty}[{size}]")), | |||
| Err(ty) => Err(format!("{ty}[{size}]")), | |||
| }, | |||
| IdlType::Generic(..) | |||
| | IdlType::GenericLenArray(..) | |||
| | IdlType::DefinedWithTypeArgs { .. } => Err("generics are not supported".into()), | |||
There was a problem hiding this comment.
I'm hoping you are prepared to overlook this warning (note that overall code coverage has increased)
There was a problem hiding this comment.
I liked this feature of pointing out lines not covered by tests.
seanyoung
changed the title
LucasSte
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all the crates which can be updated easily.