Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stall Level 0 and 1 #1186

Merged
merged 10 commits into from
Jan 15, 2020
Merged

Do not stall Level 0 and 1 #1186

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b92db4
Do not stall Level 1
Jan 8, 2020
47fd68f
Merge branch 'master' into ibrahim/remove-l1-stall
Jan 9, 2020
efa2410
Add test for Level 1 stall
Jan 9, 2020
5023d8b
fix race condition
Jan 9, 2020
b5c6b6a
Do not stall level 0
Jan 10, 2020
d444b41
refactor test
Jan 13, 2020
b0dc742
do not sort compaction priorities
Jan 13, 2020
31a7c83
Add missing unlock
Jan 13, 2020
72e67cb
add comment
Jan 14, 2020
952173b
Fix windows build
Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions levels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,15 +925,13 @@ func (s *levelsController) addLevel0Table(t *table.Table) error {
s.cstatus.RUnlock()
timeStart = time.Now()
}
// Before we unstall, we need to make sure that level 0 and 1 are healthy. Otherwise, we
// will very quickly fill up level 0 again and if the compaction strategy favors level 0,
// then level 1 is going to super full.
// Before we unstall, we need to make sure that level 0 is healthy. Otherwise, we
// will very quickly fill up level 0 again.
for i := 0; ; i++ {
// Passing 0 for delSize to compactable means we're treating incomplete compactions as
// not having finished -- we wait for them to finish. Also, it's crucial this behavior
// replicates pickCompactLevels' behavior in computing compactability in order to
// guarantee progress.
if !s.isLevel0Compactable() && !s.levels[1].isCompactable(0) {
// It's crucial that this behavior replicates pickCompactLevels' behavior in
// computing compactability in order to guarantee progress.
// Break the loop once L0 has enough space to accommodate new tables.
if !s.isLevel0Compactable() {
break
}
time.Sleep(10 * time.Millisecond)
Expand Down